On Sunday 11 Dec 2005 22:51, Chris Cannam wrote: > Known problems that will be fixed: > > * The border of the audio segment isn't shown > * The preview is a bit too high up in the segment block
These are now fixed (I did switch to transparent backgrounds in the images after all). > Anyway, apart from those, I'd like feedback on whether previews appear > generally OK or not, and what the CPU consumption is like (particularly > in the original case we were addressing, where you're recording a new > segment while there are several existing audio segments on screen). This request still stands, though! And one for Guillaume. Once upon a time, we had a bug with the way audio previews were calculated when you changed zoom levels. If you moved the zoom slider rapidly, it would fire off preview calculations for each of the intermediate steps even though they were instantly made obsolete by the next step of the slider. At the time that caused crashes, as well as unnecessary work. It was fixed in two places -- stopping the crash by avoiding the problem of having nothing to call back on after the zoom level had changed again, and removing the inefficiency by cancelling any ongoing preview generation when the zoom level changed. The latter fix has now broken again. If you change zoom level twice in succession, both previews get to run to completion. The code that used to prevent this is in CompositionModelImpl::refreshAllPreviews where we delete the existing preview updaters. This function used to be called from something, when the zoom changed. There is also a comment in the CompositionView ctor: // cmi->refreshAllPreviews(); - no need, done by setZoom(1x) which suggests that there was a setZoom function that did the calling. But that function no longer exists, and it appears refreshAllPreviews is never called. Can you remember why this has happened? I guess at some point someone (presumably you) decided calling refreshAllPreviews from somewhere was overkill, or changed the whole way zoom was handled. I obviously want to restore this behaviour, but I don't want to risk cutting off audio previews that we actually do need. Chris ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_idv37&alloc_id865&op=click _______________________________________________ Rosegarden-devel mailing list Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
