On Monday 19 December 2005 23:46, Chris Cannam wrote: > > Just that I think there's been too much disruption already -- I don't > think the artifacts buffer refresh stuff should have been messed with > at all at this stage (unless there's something actually wrong with it, > and I haven't seen any evidence of that yet).
The only reason I started messing with it is that dissociating the updates on the seg buffer with the global ones yielded update problems with the artifacts buffer. However looking at your changes I see that you're using the seg buf update rect differently from me. > The crucial, trickiest > bit to get right is the contents of checkScrollAndRefreshDrawBuffer, > and I don't think that's right at all in HEAD. May be, that's your code so I really can't tell. > I mean that the point at which I started getting worried about all this > was the point where you started messing about applying refresh > rectangles to the artifacts buffer. The artifacts buffer has the > advantage of being fairly simple: leave well alone, unless you find an > actual problem with it. As I said, that's what happened. All I was doing far further clearing up the distinction between updating the segments buffer and the artifacts one, but I didn't added an artifacts buffer update rect. > > I'd apply it to HEAD with a few reserves, like the renaming back of > > slotUpdateSegmentsDrawBuffer() to slotUpdate(). > > It's not really renaming _back_ -- I just never used that update, I > backed out your last few commits and started from earlier on at a point > where I was less confused. I should have branched from that earlier > point too, but by the time I thought of branching it was a bit too > late. So no, I've no problem with that change. OK, I'll merge your changes back in HEAD and redo the rename. > I have yet to find any other way to force the pointer-position change > update and the segment-size change update to come through as two > separate paint events rather than one big one. If you can find one, > please do. QPaintEvent also carries a QRegion, which is an array of QRects. That's probably what we're looking for. -- Guillaume. http://www.telegraph-road.org ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
