On Mon, Jan 16, 2006 at 01:09:44PM +0000, Chris Cannam wrote:
> Several of these conversions would be better done with qstrtostr and
> strtoqstr
> (see rosestrings.h). That generally applies to user-visible text strings
> rather than e.g. filenames.
Aha, didn't know about those functions. Yea, that's definitely
better.
>
> Is it actually necessary to write e.g.
>
> QString qstr = (const char *)mystring.c_str();
>
> What happens if you omit the cast, which I would (foolishly?) expect to be
> unnecessary?
You're right, everything's fine. I've never used Qt before, so I just
stuck the maximal amount of typing information to make sure that
things were right. But yea, the cast can be dropped with no problem.
> I've committed a set of changes that take these adjustments into account and
> that I hope should still work for you. Do let us know if they don't.
I just checked out your changes and I'm still seeing this:
g++ -I/usr/include/alsa -I/usr/local/include -I/usr/X11R6/include
-I/usr/include/freetype2 -I/usr/include/freetype2/config -DHAVE_ALSA
-DHAVE_LIBJACK -DHAVE_DSSI -DHAVE_LADSPA -DHAVE_LIBLO -DHAVE_LIBLRDF -DHAVE_XFT
-DQT_THREAD_SUPPORT -DVERSION=\"4-1.2_cvs\" -I/opt/kde/include/
-I/usr/lib/qt/include/ -I/usr/include/alsa -I/usr/local/include
-I/usr/X11R6/include -I/usr/include/freetype2 -I/usr/include/freetype2/config
-DHAVE_ALSA -DHAVE_LIBJACK -DHAVE_DSSI -DHAVE_LADSPA -DHAVE_LIBLO
-DHAVE_LIBLRDF -DHAVE_XFT -O2 -DNDEBUG -DNO_DEBUG -I/usr/include/alsa
-I/usr/local/include -I/usr/local/include -I/usr/local/include
-I/usr/X11R6/include -I/usr/include/freetype2 -I/usr/include/freetype2/config
-IRGbuild/gui -IRGbuild -I. -I/usr/X11R6/include/X11/Xft -IRGbuild/base
-IRGbuild/sound -c -o RGbuild/gui/audiomanagerdialog.o
RGbuild/gui/audiomanagerdialog.cpp
RGbuild/gui/audiomanagerdialog.cpp: In member function `void
Rosegarden::AudioManagerDialog::slotDeleteUnused()':
RGbuild/gui/audiomanagerdialog.cpp:1011: error: no match for 'operator[]' in '
nameMap[Rosegarden::SoundFile::getFilename() const()]'
/usr/include/c++/3.3.4/bits/stl_map.h:312: error: candidates are: _Tp&
std::map<_Key, _Tp, _Compare, _Alloc>::operator[](const _Key&) [with _Key =
QString, _Tp = AudioFileId, _Compare = std::less<QString>, _Alloc =
std::allocator<std::pair<const QString, AudioFileId> >]
RGbuild/gui/audiomanagerdialog.cpp: In member function `void
Rosegarden::AudioManagerDialog::slotRename()':
RGbuild/gui/audiomanagerdialog.cpp:1078: warning: `getText' is deprecated
(declared at /opt/kde/include/klineeditdlg.h:98)
RGbuild/gui/audiomanagerdialog.cpp: In member function `bool
Rosegarden::AudioManagerDialog::addFile(const KURL&)':
RGbuild/gui/audiomanagerdialog.cpp:1274: warning: `download' is deprecated
(declared at /opt/kde/include/kio/netaccess.h:116)
scons: *** [RGbuild/gui/audiomanagerdialog.o] Error 1
scons: building terminated because of errors.
--
Ross Vandegrift
[EMAIL PROTECTED]
"The good Christian should beware of mathematicians, and all those who
make empty prophecies. The danger already exists that the mathematicians
have made a covenant with the devil to darken the spirit and to confine
man in the bonds of Hell."
--St. Augustine, De Genesi ad Litteram, Book II, xviii, 37
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
