On Friday 13 April 2007 08:45, Arnout Engelen wrote: > I've been looking into the way Notes with NoAccidental are handled, and > I think there's room for improvement.
Sorry, I've only just got around to looking at this. > This way, going back to my example above, the Ab in F major would get a > flat (since it's 3 semitones from the F). After transposition, it's > still 3 semitones from the tonic, so it still gets a flat, yielding Bb, > which is indeed a major second from Ab. > > This is of course not perfect, but I think it will handle the common > cases better, and the rare cases not worse :). I think your explanation and reasoning look right. > This sounds like it'd make sense to add some constants: > > NoAccidentalStrategy::useSharps (always prefer sharps) > NoAccidentalStrategy::useFlats (always prefer flats) > NoAccidentalStrategy::useKeySharpness (current behaviour) > NoAccidentalStrategy::useKey (behaviour proposed above) That sounds like a good idea too. I can't think of any obvious problems with this, apart from tidying up all the loose ends, and most of those ends are loose because I was too lazy to provide a proper mechanism for demanding flats or sharps explicitly, like the one you've just suggested. So tidying those up would be worthwhile anyway. Chris ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
