On Saturday 21 April 2007 13:55, Arnout Engelen wrote:
> As promised: this seems to work well here, if you don't see any problems
> with it I'll commit it for broader testing ;).

I see you've committed it now -- OK by me, thanks.  I've looked it over and I 
think I want to look it over again before I'll understand what it's actually 
doing, but best not to wait on that.

One thing I will complain about is that it doesn't follow our code layout 
standard (opening brace at end of line, except at start of function block; 
four-space indentation; no explicit tab characters, only spaces).  Our code 
was inconsistent in this respect until recently, but when we reorganised the 
code in Subversion we also imposed a single consistent format across almost 
the whole codebase (although we probably did miss parts of the base and sound 
directories).  So now we really should require new code to stick to it.


Chris

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to