On Mon, Sep 8, 2008 at 6:09 PM, <[EMAIL PROTECTED]> wrote: > Revision: 9174 > http://rosegarden.svn.sourceforge.net/rosegarden/?rev=9174&view=rev > Author: emrum > Date: 2008-09-08 17:09:24 +0000 (Mon, 08 Sep 2008) > > Log Message: > ----------- > misc fixes > AudioFileManager.cpp now compiles, but still needs review
Can we pause to agree on a definite policy for this kind of change? This revision consisted partly of removing a feature, by commenting out a use of QUrl (in order to get the file to compile) rather than completing the conversion of it. (Emanuel marked the omission with a big honking //@@@ comment -- it isn't just a silent change.) What do we think of this kind of thing? On the one hand it should permit building the application sooner; on the other hand it risks us leaving a feature incomplete and forgetting ever to restore it (especially if it's a subtle one). I think I could agree to either policy -- "convert everything, leave nothing out" or "get it to compile and then put the lost bits back in" -- but whatever we do, we should be sure to agree on it, so that we can have a concerted effort to go and fix all the remaining //@@@ points afterwards before releasing anything. Chris ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
