On Fri, Sep 12, 2008 at 3:06 PM, Julie S <[EMAIL PROTECTED]> wrote: > I decided to take up the task of going through all the .startGroup / > .endGroup matching stuff for QSettings.
I might as well reply with what my impression is, though Emanuel will likely have more idea about these changes so far (since he made most or all of them). I'm pretty sure his changes to date have an automated aspect, which probably explains some of the strange details (such as m_cfg for a local variable name). > Unfortunately, QSettings are still being passed as arguments in the function > call--which I know we've talked about. [...] First are we leaving this as is > for now? I think we should remove them. > TabbedConfigurationPage(cfg, parent, name), ... and from the base class too. > At bottom of snippet, we are creating m_cfg, on the stack. m_cfg is not a > member function--not listed in .h file. So, it should not be m_cfg, since > the 'm_' indicates a member function. Right, I assume this is just because it was previously a member variable and the replacement that has occurred changed only the declaration, not the variable name. Fixing this sort of thing would certainly be nice, yes. > I also see multiple redeclarations of QSettings within a function and lots of > .startGroup with the same group as the previous group--so I am just leaving a > /### note indicating the .startGroup that was called for reference in case I > mess up the process. Right, multiple QSettings definitions in the same function should ideally be condensed into one definition and a bunch of startGroup/endGroup calls on it. Chris ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
