On 02/19/2010 12:45 PM, Chris Cannam wrote: > On Fri, Feb 19, 2010 at 9:06 AM, Dave Plater <[email protected]> wrote: > >> I've copied and fixed the desktop file a long time ago and install it >> separately on openSUSE. >> > Should we be including that one in our source tree? > > Or perhaps better put: can we provide one that pleases everyone from the > outset? > > > Chris > > If you run desktop-file-validate on your existing rosegarden.desktop and remove any complaints it produces then I'm sure all freedesktop.org compliant distros will be happy and I can remove my extra one from my package. All this said, I haven't checked the supplied desktop file for a long time, just did and these are the complaints :- rosegarden-10.02/data/desktop/rosegarden.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated rosegarden-10.02/data/desktop/rosegarden.desktop: warning: value "rosegarden.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path rosegarden-10.02/data/desktop/rosegarden.desktop: warning: key "DocPath" in group "Desktop Entry" is a reserved key for KDE
I use /usr/share/pixmaps/ for the icons ATM and it's apparently depreciated but the only complaint I get which is ignored by opensuse build service is :- rosegarden.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated I can't remember what I did with the complaint about the icon in your desktop file but I made an xpm icon and gave an absolute path to /usr/share/pixmaps/rosegarden.xpm, categories changed to :- Categories=AudioVideo;Midi;Sequencer;X-SuSE-Sequencer;X-Red-Hat-Base; because the rpmlint check complained about "Audio" and I removed DocPath completely with no ill effects. Interestingly enough I had a complaint when I removed "Encoding" so I just left it in and the build service check doesn't seem to mind either. Regards Dave P ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
