Hello Ted,
I just saw your commit and your questions about how to handle the error.
I don't see any harm in just splitting, allowing the split command to decide
not to act, and just adding the command to the history.
I'd imagine this situation is a corner case. Sometimes several segments are
split with one user call. So we don't want to clutter the operation with a
message box or anything (which was my initial thought.
As long as the execute and unexecute command handle this situation correctly, I
don't see the harm in just adding them to the History.
But this is not a strongly held opinion.
Skipping the add to the command history is fine as well.
I can see this either way.
...
I didn't look deeply into the exact area your commit affected but I tried this
before and after your commit and got the same result:
* Draw segment starting on measure 2 (MIDI Track)
* Move position indicator to start of measure 2
* Segment->Split->Split at Time...
* Press OK in dialog (uses position indicator as time)
This creates two segments, one of which is 0 duration. This is checked:
* Select a segment
* Segment->Set Duration...
And the command was added to the history.
Is this what your commit was trying to prevent, or was it for some different
command?
Sincerely,
Julie S.
------------------------------------------------------------------------------
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
