On 07/01/2013 04:01 PM, Tom Breton (Tehom) wrote: >> On 07/01/2013 03:07 PM, Tom Breton (Tehom) wrote: >>> Please tell me if there are any problems.
This feels odd to me: // #define DEBUG_SEQUENCE_MANAGER 1 #if !defined DEBUG_SEQUENCE_MANAGER #define NDEBUG 1 #endif NDEBUG is used to change the behavior of code based on whether or not the build is a debug build. In rg, it is used about 27 times for this purpose. Doing this changes the meaning of NDEBUG and would surprise someone who wanted to use it in this file. NDEBUG is sort of a reserved #define that probably shouldn't be modified. The removal of #ifdef DEBUG_SEQUENCE_MANAGER ...is a bit unsettling to me in general as that's just the way things are usually done all throughout rg. Consistency is helpful, form is liberating, war is peace, all that good stuff. That said, the proliferation of verbose #ifdef DEBUG_SEQUENCE_MANAGER ...is definitely an eye-sore. Maybe if some sort of disable (kill?) switch were embedded in SEQMAN_DEBUG (and friends) to get rid of obnoxious logging? Something that is reserved for file scope disabling. Like: #define STOP_THE_FLIPPING_DEBUG_OUTPUT_IN_THIS_FILE_ONCE_AND_FOR_ALL 1 That would be nice. Although it is a bit obtuse as one must remember it is available and that it might be the reason the debug output isn't working. The ugly/verbose #ifdef DEBUG_SEQUENCE_MANAGER is pretty easy to spot and grasp. Anyway, minor stuff. Ted. ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Rosegarden-devel mailing list Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
