I think I fixed it. But it makes little sense. So I'm not sure.
Read on...
First, I confirmed that Philip's change works. Doing a full update()
for the pointer position appeared to fix this. So that got me thinking
about update()...
MatrixScene::handleEventRemoved() calls QGraphicsScene::update(). I
would expect that to handle this. I even added an invalidate() for fun,
no difference.
So then I tried something crazy. Just to make sure that update()
call in MatrixScene::handleEventRemoved() was doing something, I removed it.
And now it works fine. Even tested deleting in Notation to make sure
the note goes away on Matrix. Works fine.
Theories? Do we go with this for 22.06?
Ted.
On 6/3/22 4:42 PM, Philip Leishman wrote:
I have been experimenting a bit here.
I can only reproduce the error if the pointer position is within the
segment.
with the pointer position at the start of the composition try a segment
starting at bar 2. I do not get the error.
Move the pointer to bar 3 and create a segment from bar 2 to bar 4. Now
I get the error.
Looking into Panned.cpp:
There are 2 showPositionPointer routines. One is used by the notation
editor and one by the matrix editor.
The Notation editor version uses viewport()->update(). The matrix editor
version calls viewport()->update(newRect).
If I change to the viewport()->update() call the bug seems to disappear
!!!!
Don't ask me to explain this but maybe someone can confirm this behavior.
Philip
On 6/2/22 20:38, Ted Felix wrote:
On 6/2/22 1:06 PM, mark_at_yahoo via Rosegarden-devel wrote:
I'm looking forward to seeing the fix. :)
Yeah. This is a strange one. So everyone sees it no matter what
version of Qt. I'm guessing it was introduced when we added the
toolbar undo history dropdown. 21.06 doesn't seem to have the
problem. Haven't actually bisected to see if that's really it, though.
Don't have a lot of hope for fixing this for 22.06. Ah well. I'll
see if I can come up with something clever given that it is likely to
affect anyone who uses the toolbar.
Ted.
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to
unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
_______________________________________________
Rosegarden-devel mailing list
Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
