pmatilai commented on this pull request.
rpmlog(RPMLOG_ERR, ...) does not stop the build any more than the
rpmlog(RPMLO_WARNING, ...) does a few lines below. As you should've noticed
when testing it.
Another possible (not saying it's good or what I want, just enumerating)
approach would be adding a macro config option to terminate build on
macros-in-comments. Ie use what's already there but make it an error (which
actually terminates) if configured that way.
What I really wonder though is what exactly are you doing that you're
constantly running into this in a harmful way? Distros have thousands of
packages and hundreds of developers too, and yes new people hit this every now
and then, but I don't see riots because of it. As in, maybe there's a better
way to accomplish what you're doing.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/124#pullrequestreview-16550683
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
