Seems I missed the return with error code earlier, possibly due to testing by
commenting %configure in %prep where this doesn't do anything at all. So it
seems to do what it promises in eg spec preample, but spec scriptlets are
special for the macro expansion warning already.
I'm not really happy with any of the existing or proposed macros-in-comments
hacks. Most of the time expanding macros in comments is perfectly harmless and
the warning rpm currently emits is just unnecessary noise, and yet does not
warn in many cases where it would matter. And this outlaws commenting multiline
macros. Which, if you really think about it, seems totally absurd.
If we end up agreeing that multiline macros are special enough that we need to
do something differently wrt them then we might as well do what the user
intended and not expand the bleeping line, instead of failing with an unhelpful
error.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/124#issuecomment-273499005
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
