> There are many good use cases for doing %check on the content of %install.
>
> Your suggestion is to do a fake install in %build and check that, but that 1.
> won't test the actually installed stuff, 2. make me copypaste possibly lots
> of code (not all %install sections are just %make_install!!) and keep it with
> only slight changes in two places.
It's not that I'm opposed to testing the actually installed content, the issue
is that the pre-packaging phase is the wrong place to do that because it can
(and as we've seen, does) affect what is being packaged. Which is not okay at
all, I'm sure everybody can agree with *that* point. Also, it does not actually
test the installed stuff because it's in this arbitrary empty root at arbitrary
path which is nothing like the environment where the code will actually execute
and may require extra content to run at all (the very Python example that lead
us to this).
It's also not that autotools is somehow good example to follow, it's just that
"%check" was quite clearly inspired by autotools "make check", but only run at
the wrong time. Which is why we have a multiple (interlinked) problems, which
wont go away by themselves.
Testing actually installed stuff can only happen from an actual installation of
that stuff, and inside rpmbuild is not really the place to do that.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1618#issuecomment-814876239
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
