@pmatilai commented on this pull request.
> {0, 0, 0, 0}
};
/**
*/
static int findPreambleTag(rpmSpec spec,rpmTagVal * tag,
- const char ** macro, char * lang)
+ const char ** macro, char * lang, int * beforebuildonly)
findPreambleTag() is of course pre-existing code that just gets extended here
so this is just a side-remark, but this function sure looks like it'd be much
saner to just return a pointer to the struct instead of all these separate
return pointers.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2917#pullrequestreview-1908639748
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2917/review/1908639...@github.com>_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
