@pmatilai commented on this pull request.


> @@ -1060,71 +1069,72 @@ typedef const struct PreambleRec_s {
     int type;
     int deprecated;
     int ismacro;
+    int beforebuildonly;

This is certainly better than the not-version (negations in variable names are 
the wrong thing, every time), just looks somehow out of place in that company. 
"prebuild" maybe? Not that this name is a hill to die for :laughing: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2917#pullrequestreview-1916104539
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2917/review/1916104...@github.com>
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to