https://bugzilla.rpmfusion.org/show_bug.cgi?id=4892
--- Comment #7 from leigh scott <[email protected]> ---
(In reply to David Demelier from comment #6)
> (In reply to leigh scott from comment #4)
> > (In reply to David Demelier from comment #3)
> > > Thank for the review, I think I have covered many of the comments.
> > >
> > > Here's the v2:
> > >
> > > SPEC: http://markand.fr/static/rpms/v2/retroarch.spec
> > > SRPM: http://markand.fr/static/rpms/v2/retroarch-1.7.2-1.fc28.src.rpm
> > >
> > > Regards.
> >
> > I missed these in files, please remove
> >
> > %{_docdir}/retroarch/COPYING
> > %{_docdir}/retroarch/README.md
>
> If I remove those, I get rpmbuild telling that the files are installed but
> not listed:
>
> error: Installed (but unpackaged) file(s) found:
> /usr/share/doc/retroarch/COPYING
>
> Should I keep them or remove them at %install step?
Yes delete it and let %doc install it instead
%{buildroot}%{_sysconfdir}/retroarch.cfg
# Don't install COPYING as doc should do it
rm %{buildroot}%{_docdir}/retroarch/COPYING
%files
%doc README.md
%license COPYING
%dir %{_libdir}/retroarch/
%{_bindir}/retroarch
%{_bindir}/retroarch-cg2glsl
%{_datadir}/applications/retroarch.desktop
%{_datadir}/pixmaps/retroarch.svg
%{_mandir}/man6/retroarch-cg2glsl.6.*
%{_mandir}/man6/retroarch.6.*
%{_sysconfdir}/retroarch.cfg
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug._______________________________________________
rpmfusion-developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]
