On Thu, Jun 10, 2010 at 1:58 AM, Rainer Gerhards <[email protected]> wrote: > > Looking at omfile implementation as an example, there *are* lots of things > guarded by this look. Just think about the dynafile cache, the ZIP writer or > the background write process. All of them use relatively simple algorithms > based on the assumption that the core guarantees exclusive use of the > instance data structures. Removing that guarantee is a non-trivial task.
I'd like to see the dynafile cache go away, personally. That section of code has always felt problematic, and it seems that there would be significantly more effective ways of doing the same task. I personally prefer the timeout method where files idle for x seconds are closed out. I am of the opinion that the current approach is just generally bad. In the case of compression, couldn't that simply sit inside the same lock used for writing, just prior to the write() itself? -Aaron _______________________________________________ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com
