On Tue, 22 Jun 2010, Rainer Gerhards wrote:
>> -----Original Message-----
>> From: [email protected] [mailto:rsyslog-
>> [email protected]] On Behalf Of Jeff Turner
>>
>> <input type="imtcp"><params listen="10515" ruleset="remote10515" />
>> </input>
>>
>> just become:
>>
>> <input type="imtcp" listen="10515" ruleset="remote10515" />
>
> It's a problem of namespace pollution. In the sample I gave, attributes were
> used for parameters which are supported by the rsyslog core, so they always
> exist. Those in params were module-specific. If all of them are either
> parameters or all are attributes, I have the problem that rsyslog may define
> a new parameter that someone somewhere has used as parameter inside a module,
> so I would potentially break compatibility.
I'm not seeing a problem here
there's nothing that prevents you from having
<imtcp listen='10515' ruleset="remote10515" />
there are definantly problems if you try to do
<input type="imtcp">
<listen port='10515' />
<rulest name="remote10515" />
</input>
because you want to use the tag ruleset elsewhere to specify the ruleset.
>> Overall though, after the initial curve I've come to quite like the old
>> format :) A good format is one that is optimized for common cases. For
>> syslog that is simple statements like:
>>
>> mail.* -/var/log/mail.log
>> user.* -/var/log/user.log
>>
>> which becomes very verbose under XML:
>>
>> <ruleset id="default">
>> <rule>
>> <filter pri="mail.*"/>
>> <action type="omfile">
>> <params file="/var/log/mail.log" sync="false"/>
>> </action>
>> </rule>
>> <rule>
>> <filter pri="user.*"/>
>> <action type="omfile">
>> <params file="/var/log/user.log" sync="false"/>
>> </action>
>> </rule>
>> </ruleset>
what I am suggesting is somewhere in between
<ruleset id='default' >
<rule pri="mail.*">
<omfile file="/var/log/mail.log" sync="false"/>
</rule>
<rule pri="user.*">
<omfile file="/var/log/user.log" sync="false"/>
</rule>
</ruleset>
_______________________________________________
rsyslog mailing list
http://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com
