05.11.2013 20:18, Rainer Gerhards:
Maybe it will break, maybe not. If the problem is in watermarks, then it
is not a problem of queue size.
Btw, I've just tested it - and it works.
Have you really tested it? with pure disk queues, DA queues, linkedList and
FixedArray?
Of course, not. I have not checked it with disk queues. Because using
disk queues and DA queues with size=1 does not make sense even for me.
Should I?..
well.. strange use cases may pop up every now and then. The question is
what is to best benefit of the project. Take the current situation. We
started with global variables, something that has broader use, but still is
not a mainstream use.
Global variables in themselves cannot justify such a rewrite, maybe it
was needed anyway.
There is need for consistency throughout the project. To keep things
simple for an user, each building block should behave in expected way.
Sometimes, it is tradeoff between performance and abstractness, but
often it just can be done. Border cases are hard to debug, of course,
but they are also most useful when debugging, and they *can* be useful
for some use-cases, which will not work without them, anyway. Every
covered use case, even when it was unintentional, can be good for the
community project.
Btw, now it is possible to configure size="0" and then the queue will
mysteriously fail to start. Or size="3000000000", the same outcome. And
it is possible to set size="-100" which results in a segfault. Or
size="ThirteenBugz", also segfault. *These* are real invalid settings.
--
Pavel Levshin
_______________________________________________
rsyslog mailing list
http://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com/professional-services/
What's up with rsyslog? Follow https://twitter.com/rgerhards
NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of
sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE
THAT.
