Ok, it passes on travis now. Waiting for Thomas to confirm as well. To be clear, uninitialized pointer wasn't the cause (it was being initialized later, I spoke too soon). The problem was the o_type check I added was preventing the key-dereference, but was returning incorrect value (indicating that dereference was successful, so code using the returned value started segfaulting).
On Tue, Jan 20, 2015 at 8:48 PM, singh.janmejay <[email protected]> wrote: > Yep, true. It won't catch all bugs no matter what we do. > > @Thomas: I have pushed another patch to the same PR, can you pull and try? > > On Tue, Jan 20, 2015 at 8:45 PM, Rainer Gerhards <[email protected] > > wrote: > >> 2015-01-20 15:54 GMT+01:00 Thomas D. <[email protected]>: >> >> > Definitely confirmed: >> > >> > Your patch only works when using CFLAGS="-O0"... when using CFLAGS="-O2" >> > (default) it is still failing. >> > >> > >> > When I first confirmed it was working, I was still using "-O0" I used >> > for setting up the debug environment... :> >> > >> > >> yeah, remember that discussion late last year where I said that in testing >> we have the problem that the number of tests exponentially grows and it is >> simply impossible to try to do that. This here is just one of the many >> facets it has. Don't get me wrong: I think the addition of daily testbench >> runs and now Travis CI is definitely exteremely helpful. But we will >> always >> have situations which we don't catch... unfortunately. >> >> Rainer >> >> > >> > >> > -Thomas >> > >> > >> > _______________________________________________ >> > rsyslog mailing list >> > http://lists.adiscon.net/mailman/listinfo/rsyslog >> > http://www.rsyslog.com/professional-services/ >> > What's up with rsyslog? Follow https://twitter.com/rgerhards >> > NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad >> > of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you >> > DON'T LIKE THAT. >> > >> _______________________________________________ >> rsyslog mailing list >> http://lists.adiscon.net/mailman/listinfo/rsyslog >> http://www.rsyslog.com/professional-services/ >> What's up with rsyslog? Follow https://twitter.com/rgerhards >> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad >> of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you >> DON'T LIKE THAT. >> > > > > -- > Regards, > Janmejay > http://codehunk.wordpress.com > -- Regards, Janmejay http://codehunk.wordpress.com _______________________________________________ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com/professional-services/ What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
