Also, why do you say it won't handle escaped sequences? It it doesn't, there will be no way to put a % or : in the string you provide (in addition to trouble with unicode characters).
On Tue, Jan 27, 2015 at 10:21 AM, singh.janmejay <[email protected]> wrote: > @David: > > +1 for making this an option to existing quoted-string (instead of > introducing a new type) > > -1 for 'or' > > +1 for keeping old behaviour the default with quited-string. > > @Chris: > > Once we have agreement on best way of doing it, will it be possible for > you to add tests for the new functionality? > > Adding new tests is trivially easy once you have looked at existing ones. > > Also, it'll be even better if you can add a little bit of documentation. > Here is the file you want to add it to: <root>/doc/configuration.rst > > > > On Tue, Jan 27, 2015 at 6:19 AM, David Lang <[email protected]> wrote: > >> I don't like the "or" option as I think it makes the rules harder to >> read. unless you are doing this on a lot of fields in a line, just make a >> new line with the different type. >> >> We need feedback from others, but at the very least I think making this >> an option to the standard quoted-string type would be better than a new >> type (the question is if this should be enabled by default or disabled by >> default) >> >> >> David Lang >> >> On Tue, 27 Jan 2015, Chris Schafer wrote: >> >> It comes back as a full fail. I thought about modifying that, but I >>> didn't >>> want to wreck anything currently in place. >>> A coworker of mine had a great idea for an "or" ability, going >>> %tag:or:quoted-string:word% where i attempts the first, and if that >>> fails, >>> goes to the second. However, that's not going to be easy, and I wanted to >>> push this change before you guys got too many commits ahead. >>> >>> On Mon Jan 26 2015 at 4:43:02 PM David Lang <[email protected]> wrote: >>> >>> hmm, I'm wondering if we should do this for the normal quoted type? If >>>> you >>>> say >>>> quoted string and there isn't a quote does it just not match? >>>> >>>> David Lang >>>> >>>> On Tue, 27 Jan 2015, Chris Schafer wrote: >>>> >>>> This only handles " because that's what the current quoted string does. >>>>> If it doesn't start with ", it implements the "word" functionality >>>>> >>>> (which I >>>> >>>>> shamelessly copied). The idea is to capture inputs where the source >>>>> >>>> system >>>> >>>>> only quotes it if it contains a space, but leaves it unquoted >>>>> otherwise. >>>>> Example: >>>>> No data = - >>>>> One Word = word >>>>> Two words+ = "Two Words" >>>>> >>>>> The function should handle all three. >>>>> Chris >>>>> >>>>> On Mon Jan 26 2015 at 4:36:25 PM David Lang <[email protected]> wrote: >>>>> >>>>> does this handle embedded quotes in the string? and do you handle >>>>>> >>>>> strings >>>> >>>>> starting with ' and " or just one of them? >>>>>> >>>>>> David Lang >>>>>> >>>>>> On Tue, 27 Jan 2015, Chris Schafer wrote: >>>>>> >>>>>> Date: Tue, 27 Jan 2015 00:30:54 +0000 >>>>>>> From: Chris Schafer <[email protected]> >>>>>>> Reply-To: rsyslog-users <[email protected]> >>>>>>> To: [email protected] >>>>>>> Subject: [rsyslog] New Pull request for liblognorm - additional >>>>>>> >>>>>> mmnormalize >>>>>> >>>>>>> functionality >>>>>>> >>>>>>> Just submitted the following pull request: >>>>>>> https://github.com/rsyslog/liblognorm/pull/20 >>>>>>> And I believe it could solve a lot of issues (at least, it solves a >>>>>>> lot >>>>>>> >>>>>> of >>>>>> >>>>>>> mine) surrounding mmnormalize parsing in rsyslog. I'm looking for >>>>>>> comments/issues/holy-crap-you-can't-code-what-are-you-doing, if you >>>>>>> >>>>>> guys >>>> >>>>> have any. This is my first time submitting a patch to a large project >>>>>>> >>>>>> (or >>>> >>>>> at least one where I didn't know the maintainer personally), so be >>>>>>> >>>>>> gentle >>>> >>>>> please :) >>>>>>> >>>>>>> Chris >>>>>>> _______________________________________________ >>>>>>> rsyslog mailing list >>>>>>> http://lists.adiscon.net/mailman/listinfo/rsyslog >>>>>>> http://www.rsyslog.com/professional-services/ >>>>>>> What's up with rsyslog? Follow https://twitter.com/rgerhards >>>>>>> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a >>>>>>> >>>>>> myriad >>>> >>>>> of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you >>>>>> DON'T LIKE THAT. >>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>> rsyslog mailing list >>>>>> http://lists.adiscon.net/mailman/listinfo/rsyslog >>>>>> http://www.rsyslog.com/professional-services/ >>>>>> What's up with rsyslog? Follow https://twitter.com/rgerhards >>>>>> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a >>>>>> myriad >>>>>> of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you >>>>>> DON'T LIKE THAT. >>>>>> >>>>>> _______________________________________________ >>>>> rsyslog mailing list >>>>> http://lists.adiscon.net/mailman/listinfo/rsyslog >>>>> http://www.rsyslog.com/professional-services/ >>>>> What's up with rsyslog? Follow https://twitter.com/rgerhards >>>>> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a >>>>> myriad >>>>> >>>> of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you >>>> DON'T LIKE THAT. >>>> >>>>> >>>>> _______________________________________________ >>>> rsyslog mailing list >>>> http://lists.adiscon.net/mailman/listinfo/rsyslog >>>> http://www.rsyslog.com/professional-services/ >>>> What's up with rsyslog? Follow https://twitter.com/rgerhards >>>> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad >>>> of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you >>>> DON'T LIKE THAT. >>>> >>>> _______________________________________________ >>> rsyslog mailing list >>> http://lists.adiscon.net/mailman/listinfo/rsyslog >>> http://www.rsyslog.com/professional-services/ >>> What's up with rsyslog? Follow https://twitter.com/rgerhards >>> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad >>> of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you >>> DON'T LIKE THAT. >>> >>> _______________________________________________ >> rsyslog mailing list >> http://lists.adiscon.net/mailman/listinfo/rsyslog >> http://www.rsyslog.com/professional-services/ >> What's up with rsyslog? Follow https://twitter.com/rgerhards >> NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad >> of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you >> DON'T LIKE THAT. >> > > > > -- > Regards, > Janmejay > http://codehunk.wordpress.com > -- Regards, Janmejay http://codehunk.wordpress.com _______________________________________________ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com/professional-services/ What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
