Hi David, You wrote: > can you tell at teh configure step if you are building from source or from > a release tarball?
Good question. I am undecided whether this is a good idea and something we should do or not. a) We could check for the target file like we are doing it for the man pages and rst2man. But this is prone to error: If you are going to patch a source file, make knows it has to regenerate the target but we don't know that when checking for the target file. So maybe we detect the outdated target file and make bison optional, make will still fail... b) Make bison required per default and add an option to make it optional per default (something like "--disable-generate-man-pages). c) We can check if we are running from a Git repository (test -d ".git"). When running from git, depend on bison otherwise skip or just warn. After writing this (and discussing the topic in #autotools on freenode) I thing we should go with option c (check for .git) and also adjust the way we decide whether we depend on rst2man or not (i.e. remove the "--disable-generate-man-pages" option too which isn't clean and prone to error. We can make the same assumption like we would do for bison: When building from git we require rst2man because there aren't pre-generated files in source. But when running from release tarball we assume they are present (per definition) and don't need to check). > (and what are you meaning by a release tarball? how it it > generated from a git checkout?) When Rainer and his team prepares a new release they are calling "make dist" or "make dist-check" which will generate these files. It is no explicit dist target rule, it is some kind of automake magic: > [...] > The intermediate files generated by yacc (or lex) will be included in > any distribution that is made. That way the user doesn't need to have > yacc or lex. > [...] >From http://www.gnu.org/software/automake/manual/html_node/Yacc-and-Lex.html -Thomas _______________________________________________ rsyslog mailing list http://lists.adiscon.net/mailman/listinfo/rsyslog http://www.rsyslog.com/professional-services/ What's up with rsyslog? Follow https://twitter.com/rgerhards NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE THAT.
