Hi,

Michael Biebl wrote:
>> I would suggest that "make clean" should not remove any
>> pre-generated files if configure detected that we are running from
>> release tarball. Any objections?
>
> That's hard to detect. E.g. I commit the release tarballs to git and 
> build the packages from there. So the test for .git is not a 
> sufficient indication if yacc/flex will be needed or not.

I don't get that point. We don't just check for .git, see
http://git.io/vTlHJ & http://git.io/vTl9L

We decided in this thread that per definition when building from git
source, we require yacc/flex.. but when building from release tarball,
we don't (that's easy to detect, see http://git.io/vTl9L).

So when "make clean" removes files from release tarball, that's a bug in
my understanding. Not?


> What I do notice though, is that we have
> 
> CLEANFILES = grammar.h grammar.c
> 
> but we do not cleanup lexer.c. We should either do it for both, or 
> none, I think.

Like written above, that sounds like someone has just forgotten to add
lexer.c...


-Thomas

_______________________________________________
rsyslog mailing list
http://lists.adiscon.net/mailman/listinfo/rsyslog
http://www.rsyslog.com/professional-services/
What's up with rsyslog? Follow https://twitter.com/rgerhards
NOTE WELL: This is a PUBLIC mailing list, posts are ARCHIVED by a myriad of 
sites beyond our control. PLEASE UNSUBSCRIBE and DO NOT POST if you DON'T LIKE 
THAT.

Reply via email to