On Wed, Apr 11, 2012 at 04:35:25PM +0100, Tim Cutts wrote: > > On 11 Apr 2012, at 15:50, Kevin Falcone wrote: > > > Please don't CC developers directly, lots of us work on the > > extensions. It would be great if Tim filed his patch in the appropriate > > rt.cpan.org queue. > > I wasn't brave enough to do that. It's not an extension I use - I > wrote that patched version direct in my email with code pasted from > the CPAN code browser, so it really hasn't be tested at all. The > ColumnMap examples in the Wiki have the same "bug". Given that all > ColumnMap callbacks that worked in RT 3.8 will be affected by this, it > could be considered a regression in 4.0 I suppose; the fundamental > cause is that the callback happens in share/html/Elements/ColumnMap, > which is called by share/html/Search/Results.tsv. Unfortunately, that > callback happens *after* Results.tsv has cbballed the ScrubHTML code.
> > There might be more satisfactory and general solutions that could be > implemented in the Results.tsv mason page. Rather simplistically, it > could just run ScrubHTML across everything that comes out of the > ColumnMap. Yep, but it wants a bug somewhere (in RT for the possible regression) or in the module pointing out the problem. Possibly both, with pointers between them. I appreciate you digging into it and checking it out. -kevin
pgpO8oG7PC7tT.pgp
Description: PGP signature