On 07/02/2013 09:18 AM, Andreas Heinig wrote:
On Tuesday 02 July 2013 14:52:52 Vipul Nayyar wrote:>Hello Andreas, > >Thanks Andreas for pointing out that silly mistake. I didn't focus on other >variables being used. I've updated the patch, and wanted to ask, what >should be done when status code returned is not successful ? > >commit 9b21c1effe34cb716c00ea1c11777ef16ce9c7cc >Author: Vipul Nayyar<nayyar_vi...@yahoo.com> >Date: Tue Jul 2 12:20:49 2013 +0530 > > Updated Legacy code in arm csb337 > >diff --git a/c/src/lib/libbsp/arm/csb337/network/network.c >b/c/src/lib/libbsp/arm/csb337/network/network.c index e31bcc0..53d60d2 >100644 >--- a/c/src/lib/libbsp/arm/csb337/network/network.c >+++ b/c/src/lib/libbsp/arm/csb337/network/network.c >@@ -358,6 +358,7 @@ void at91rm9200_emac_init(void *arg) > { > at91rm9200_emac_softc_t *sc = arg; > struct ifnet *ifp = &sc->arpcom.ac_if; >+ rtems_status_code stc = RTEMS_SUCCESSFUL;I think you should name the rtems_status_code either 'sc' or 'status'. These names are used by default in most of the RTEMS modules.
Yes, status is a good name.
In your case I suggest to rename the at91rm9200_emac_softc_t variable, because sc is confusing here anyway.
The "sc" is the standard name for this in BSD code. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.hu...@embedded-brains.de PGP : Public key available on request. Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG. _______________________________________________ rtems-devel mailing list rtems-devel@rtems.org http://www.rtems.org/mailman/listinfo/rtems-devel
