On 2013-12-03 09:45, Leopold Palomo-Avellaneda wrote: > A Dimarts, 3 de desembre de 2013, Jan Kiszka va escriure: >> On 2013-12-02 16:07, Leopold Palomo-Avellaneda wrote: >>> A Diumenge, 1 de desembre de 2013, Jan Kiszka va escriure: >>>> On 2013-11-19 11:07, Leopold Palomo-Avellaneda wrote: >>>>> Hi, >>>>> >>>>> work done. Now it compiles. Still there's a driver that doesn't compile >>>>> (natsemi), but it's another problem: >>>>> >>>>> /home/users/leopold.palomo/robotica/projects/platform/rtnet- >>>>> code/drivers/rt_natsemi.c:2018:6: error: conflicting types for >>> ‘set_bit_le’ >>>>> In file included from /usr/src/linux-headers-3.8.13- >>>>> xenomai-2.6.3/arch/x86/include/asm/bitops.h:516:0, >>>>> from include/linux/bitops.h:22, >>>>> from include/linux/kernel.h:10, >>>>> from include/linux/cache.h:4, >>>>> from include/linux/time.h:4, >>>>> from include/linux/stat.h:18, >>>>> from include/linux/module.h:10, >>>>> from >>>>> /home/users/leopold.palomo/robotica/projects/platform/rtnet- >>>>> code/drivers/rt_natsemi.c:150: >>>>> include/asm-generic/bitops/le.h:57:20: note: previous definition of >>>>> ‘set_bit_le’ was here >>>>> make[4]: *** > [/home/users/leopold.palomo/robotica/projects/platform/rtnet- >>>>> code/drivers/rt_natsemi.o] Error 1 >>>>> >>>>> >>>>> Patch attached, please apply it. >>>> >>>> Thanks for the fixes, and sorry for my late reply. The patch looks good >>>> except for some small formal issues: >>>> >>>> - The patch should be accommodated with a proper commit message: >>>> >>>> <subject line> >>>> >>>> <brief description (you can follow my argumentation for Xenomai here)> >>>> >>>> Signed-off-by: ... >>>> >>>> The latter is a formal statement that you are the copyright holder and >>>> contribute it to this project under the corresponding license. >>>> >>>> - The .gitignore change is unrelated, requires a separate path >>>> >>>> I'm looking into the natsemi build issue. >>>> >>> >>> It's ok now? >>> >> >> Thanks, almost perfect. I've massaged it while applying. >> > :-D > > I understand that it's not perfect, I should have sent you the patch and some > Mediterranean wine and iberic jam for after the massage ;-)
Haha, will remind you of this next time! ;) Jan
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________ RTnet-users mailing list RTnet-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/rtnet-users
