Oh. So keep the authors part. =)

We just need to check the other points I mentioned.

Em sex, 2 de mar de 2018 11:49, geemus (Wesley Beary) <gee...@gmail.com>
escreveu:

> I'm fine with authors that way in gemspec, fwiw. It is an interesting
> pattern.
>
> Thanks Paulo for checking in and giving feedback!
>
> On Fri, Mar 2, 2018 at 7:04 AM, Paulo Henrique Lopes Ribeiro <
> plribeiro3...@gmail.com> wrote:
>
>> Hello Piotr. Good morning!
>>
>> Sorry i just got to this now.
>>
>> I would like to ask you to take a look at this wiki page:
>> https://github.com/fog/fog/wiki/Create-New-Provider-from-Scratch
>>
>> I believe most of it might be already covered since you have the code
>> finished already but there is one thing to notice.
>>
>> The `autoload` part. We had a big issue because of it so we really need
>> you to update your code to use it.
>>
>> Good examples are:
>> * https://github.com/fog/fog-xenserver/blob/master/lib/fog/xenserver.rb
>> * https://github.com/fog/fog-aws/blob/master/lib/fog/aws.rb
>>
>> I've noticed that you are doing this:
>> https://github.com/pkliczewski/fog-kubevirt/blob/a61f6bba099e2404fbace2af1e885ea934583fe4/fog-kubevirt.gemspec#L8-L13
>>
>> I'm not sure whats the intention behind it but i believe you can leave
>> just Wesley there. At least that what we are doing in the other providers.
>>
>> And we do need you to release the gem before we merge your PR into
>> `fog/fog`.
>>
>> Let me know if you need assistance with anything else.
>>
>> Best,
>>
>>
>>
>>
>>
>>
>> 2018-03-02 7:12 GMT-03:00 Piotr Kliczewski <piotr.kliczew...@gmail.com>:
>>
>>> I pushed the PRs [1][2][3]. Please take a look and let us know how to
>>> continue.
>>>
>>> Thanks,
>>> Piotr
>>>
>>> [1] https://github.com/pkliczewski/fog-kubevirt/pull/3
>>> [2] https://github.com/fog/fog/pull/3984
>>> [3] https://github.com/fog/fog-core/pull/225
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "ruby-fog" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to ruby-fog+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>
>>
>> --
>> -----------------------------------------------------
>> Paulo Henrique Lopes Ribeiro - Linkedin
>> <https://www.linkedin.com/in/paulohenriquelopesribeiro/>
>> CTO 4Shark - Website <http://www.4shark.com.br/>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "ruby-fog" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to ruby-fog+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "ruby-fog" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to ruby-fog+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
Paulo Ribeiro
CTO 4SHARK

-- 
You received this message because you are subscribed to the Google Groups 
"ruby-fog" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to ruby-fog+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to