On Fri, Jan 18, 2008 at 12:05:43PM +0100, Jean-François Trân wrote: > 2008/1/18, Matt Palmer <[EMAIL PROTECTED]>: > > Is it a bug or a feature that directories that happen to be named > > 'generators' deep inside a plugin (rather than at the top level) get > > searched for generators? > > It's a feature : > > in lib/rails_generator/lookup.rb it says : > > # Use component generators (model, controller, etc). > [...] > # 2. Look in plugins, either for generators/ or rails_generators/ > # directories within each plugin
That is still as ambiguous as the code, though -- does it mean just in the top-level, or anywhere? While the plural "directories" would suggest anywhere, but using a plural after an "or" is fairly common usage in English. Beyond that, there's still the issue of whether it's correct operation to look for those directories anywhere in the tree. After all, we don't add all 'lib' directories we happen to find in the tree to the load path (or do we? I'd hope not). > > Just trying to assess whether I should bother submitting a patch or not. > > In my opinion, you shouldn't. One vote against, then. Anyone else? - Matt --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
