> That is still as ambiguous as the code, though -- does it mean just in the
> top-level, or anywhere?  While the plural "directories" would suggest
> anywhere, but using a plural after an "or" is fairly common usage in
> English.
>
> Beyond that, there's still the issue of whether it's correct operation to
> look for those directories anywhere in the tree.  After all, we don't add
> all 'lib' directories we happen to find in the tree to the load path (or do
> we?  I'd hope not).

Yeah, it does seem kinda strange.  generators or rails_generators
directories at the top level of plugins makes sense, but crawling
around inside the folders seems messy.  If you investigate a patch,
have a look at what plugins break / might break.  We can mention the
change in the release notes, but it'd be good to have a good idea
going into the change rather than be surprised when 2.1 ships.


> > > Just trying to assess whether I should bother submitting a patch or not.
> >
> > In my opinion, you shouldn't.
>
> One vote against, then.  Anyone else?
>
> - Matt
>
>
> >
>



-- 
Cheers

Koz

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Ruby 
on Rails: Core" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to