On 17 Apr 2008, at 12:30, Murray Steele wrote: > On 17/04/2008, Frederick Cheung <[EMAIL PROTECTED]> wrote: > > In 2.0.2 quote_table_name was a no-op for the sqlite adapter (if not > overriden, which sqlite doesn't, it used to just return its argument, > but now by default it's just the same as quote_column_name). In > particular this messes with some of the eager loading stuff. for > example on sqlite 3, running > > SELECT DISTINCT "developers".id FROM "developers" LEFT OUTER JOIN > "developers_projects" ON "developers_projects".developer_id = > "developers".id LEFT OUTER JOIN "projects" ON "projects".id = > "developers_projects".project_id WHERE (projects.id = 2) LIMIT 1 > > returns the selected column as id whereas with sqlite2 it returns it > as "developers".id > [snip] > I'll bung all this in a patch (patches ?) if people are interested. > > So, that's pretty interesting, as in *my* version of sqlite3 (3.5.7) > running the above sql was returning "developers".id not just id. > And thus I had about 9 eager loading test failures, but applying > your regex fix sorts them all out. If you were to create a patch > with just that regex fix, I'd totally +1 it. > > Although, it does make me wonder if there some change between > different versions of sqlite3 that cause my version and your version > to react differently? Do we need to say something like this sqlite3 > adapter works for this version of sqlite3? > I've got an older version (3.4.0). Updating sqlite3 caused me to get those test failures on trunk too. This does sounds like a bit of a nightmare waiting to bite people on the butt. I'll write up a patch as soon as i have time
Fred --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
