Em 05-07-2010 04:30, [email protected] escreveu:
Hi,

On Jul 4, 10:20 pm, Rodrigo Rosenfeld Rosas<[email protected]>
wrote:
...
As I said, once you know the reasoning you can follow his suggestions.
It just happens that we don't use minifiers at our company since
Excuse me, but here we are talking about the JS in Rails, a framework
used by thousands!

In the case of jQuery-UJS, we are talking about 4k of JS code. I wouldn't say this is that much significative... This can reach 2k using minifiers but that means we would be saving only 2k by minifiying...

Anyway, if you think about it, I can't find any reasons why a minifier should made a mistake.


Javascript is cacheable and there is no such "one-time users" thing with
our products. The overhead is also negligible for not using any JS
minifier. I mean, even if the JS code is reduced to 1/3 that would mean
That is WRONG. Please multiply the homepage by the nr. of hits. Okay,
the reasoning for Google and Yahoo is orders of magnitude stronger...

In the context, I was talking about my individual situation...

If you feel it is not necessary pls. go ahead and don't minify your
code - but pls. leave that option open for the rest of the Rails
users. We are talking about the rules for a widely used framework, not
about individual decisions.

I'm not taking any decision at all... :) I'm just saying that I don't think the semi-colons won't make any difference here... But that is just a discussion, not a decision (I don't have any write-permission on these repositories at all :) ).

I don't mind either if they decide to use semi-colons. It won't make any differences in my opinion...

Great discussion though.

Thanks,

Rodrigo.

--
You received this message because you are subscribed to the Google Groups "Ruby on 
Rails: Core" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/rubyonrails-core?hl=en.

Reply via email to