Hi, Aaron: test_0003_can_make_a_subselect(select manager::backwards compatibility::as) test_0001_uses_alias_in_sql(select manager::initialize) Those two test failed on my MRI 1.8.7 two (but pass on MRI 1.9.2).
But they are not the test I added. The test in the patch is test_0006_should_be_threadsafe_on_sql_generation(select manager) I guess those two failing tests are separated issue need look after anyway :-) BTW: the thread safe test in the patch only fails under JRuby (because MRI dose not have native threads) -- WPC On May 10, 4:37 pm, Aaron Patterson <[email protected]> wrote: > On Tue, May 10, 2011 at 01:40:12PM -0700, wpc wrote: > > Hi, Aaron > > > After apply patch the test does pass on us. We test it using JRuby > > 1.6.0 and 1.6.1 on both OSX and Windows. On MRI the test will just > > pass anyway even before applying the patch (because of green threads). > > > Could you post which platform and jruby version are you on along with > > the test failure output? > > I'm using MRI 1.8.7. When I apply the test case provided here: > > https://github.com/wpc/arel/commit/1b51481487466510189936d9613ceba8a3... > > Two other tests fail. When I add the fix provided here: > > https://github.com/ketan/arel/commit/52dc69f5bebebb75b7b3d7bd42e839f2... > > Still those two tests fail. I've pushed a branch with the two commits > applied here: > > https://github.com/rails/arel/tree/zomg > > Here is my output when I run the suite: > > https://gist.github.com/965615 > > -- > Aaron Pattersonhttp://tenderlovemaking.com/ > > application_pgp-signature_part > < 1KViewDownload -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
