On Tue, May 10, 2011 at 04:57:47PM -0700, wpc wrote: > Hi, Aaron: > > test_0003_can_make_a_subselect(select manager::backwards > compatibility::as) > test_0001_uses_alias_in_sql(select manager::initialize) > Those two test failed on my MRI 1.8.7 two (but pass on MRI 1.9.2). > > But they are not the test I added. The test in the patch is > test_0006_should_be_threadsafe_on_sql_generation(select manager) > > I guess those two failing tests are separated issue need look after > anyway :-)
Yup, I just figured this out. Sorry about that! > BTW: the thread safe test in the patch only fails under JRuby (because > MRI dose not have native threads) I think we could get it to fail on 1.9 as it uses pthreads. I'll see what I can do! -- Aaron Patterson http://tenderlovemaking.com/
pgpp4a31iP6ci.pgp
Description: PGP signature
