On 5/30/19 2:32 PM, Kevin A. McGrail wrote: > Thanks for working on this. I'm +1 without a technical review. > > On 5/30/2019 3:27 PM, Paul Stead wrote: >> I'm at the root of the issue and ready to commit changes around this: >> >> https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7715 >> >> The changes will not affect how ruleqa works or how submissions should >> be done - please continue to submit *after 0900 UTC* >> >> Any feedback appreciated, will be applying after 1st June unless >> feedback received. >> >> Paul > >
+1 The concept sounds good and needed. I am not a perl coder and don't have the time to dive into this in detail as it would probably take me a while not being good with perl. When I looked at all of this a few years ago to get the masscheck running again, I seem to recall that I wanted to enable a triggered approach to doing something very similar to this. For other similar file transfers in the past, I would setup swatch to monitor log files to trigger file movement or renames so subsequent uploads would not overwrite previous files even uploaded seconds later. A simple shell script with a few lines triggered by swatch along with a cron entry to cleanup after X days old would do the trick. Thanks to all who took the time to look into these scripts. Trust me, I know they are a mess. This really should be rewritten to be more modular and have better logging at each step to help track down problems. Many of them simply turn on shell tracing "set +x" which is not as nice as having true debug logging. -- David Jones
