On Wed, Jun 24, 2015 at 09:10:38AM +0000, Antti Kantee wrote: > On 24/06/15 09:03, Wei Liu wrote: > >>Hmm, doesn't #ifndef __RUMP_KERNEL__ in the minios headers work here? In > >>fact, per code reading, this case should already be covered by existing > >>#ifndefs. Am I missing something? > > > >Unfortunately it doesn't work. I'm not sure why wrmsr gets leaked. > > > >It's easy to reproduce, just include sys/vnode.h in any xen device > >(say evtdev.c) and you will see that error. > > Builds fine for me with the following diff. I tried both rumpmake manually > and build-rr.sh. > > --- a/platform/xen/rumpxendev/evtdev.c > +++ b/platform/xen/rumpxendev/evtdev.c > @@ -30,6 +30,8 @@ > #include <sys/cdefs.h> > #include <sys/atomic.h> > #include <sys/kmem.h> > +#include <sys/resource.h> > +#include <sys/vnode.h> > > #include "rumpxen_xendev.h"
Right. So now I know I need to include sys/resource.h and carefully rearrange the order of headers. Now it works and I can ditch that wrmsr patch. If you have no further comment I'm going to push this series. Wei.
