On 24/06/15 09:20, Wei Liu wrote:
Right. So now I know I need to include sys/resource.h and carefully rearrange the order of headers.
Yea the kernel headers aren't necessarily self-contained. Usually they're just included in alphabetical order per class (i.e. first <sys>, then e.g. <dev> and so forth). I guess vnode.h is so late in the alphabet that if resource.h is not included explicitly, it's likely to be transitively included by something which was included earlier.
Now it works and I can ditch that wrmsr patch.
I don't understand how header order could affect wrmsr leaking from the Mini-OS headers, but if it's fixed, good. I don't think this is a case where not going to the bottom of things will come back to bite us later.
If you have no further comment I'm going to push this series.
Go ahead, thanks.
