On Jul 22, 2014 5:16 PM, "Antti Kantee" <[email protected]> wrote:
>
> On 22/07/14 16:04, Justin Cormack wrote:
> > Attached is new version of patch.
> >
> > I decided it made more sense to limit the amount of randomness
> > supplied anyway, its just a waste of CPU and involves more rekeying
> > even if it is pseudorandomness.
>
> Why is the code in a .h? Not that it makes functional difference, but
> it's just ... odd.
Yes I know. Couldn't think of another saner way to not duplicate code and
to not leave public symbols that should be internal. Suggestions?
> And, again, use of arc4random_buf() breaks at least NetBSD 5, which at
> least used to work the last time I fixed it to work. Not sure if we
> want to use too much energy on keeping it working, but not sure we want
> to knowingly break it either.
Can add a test for 5 then.
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
rumpkernel-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/rumpkernel-users
