On Mon, Oct 27, 2008 at 09:23:25AM +0100, Frank Schmitt <[EMAIL PROTECTED]>
wrote:
> > Well, first of all, when you send patches, as a very minimum, use the same
> > style as the problem you send patches for.
>
> I don't understand this sentence.
sorry that's not your fault :) replace "problem" by "program" - i was also
debugging a linux kernel bug while writing that sentence :)
> > place for this is still the window manager, and working around stupid design
> > bugs in e.g. kde is not really the job of urxvt.
>
> My opinion differs but you are the maintainer. (BTW: The patch is not
> needed for KDE. But for e.g. for Gnome, Xfce, Fluxbox)
I just had basically a four hour talk about your patch, and here is the deal:
- the code seems to be broken - _NET_WM_ICON expects cardinals, and thus
an array of longs, but you seem to pass in two int's followed by bytes?
you would need to fix this.
- similarly, are you sure there isn't any endianness issue in the conversion?
does it really work on big-endian systems?
- fix the coding style to be the same as the rest of the code (especially
the indentation which is weird, but also curly braces and whitespace).
- make sure you set the property before urxvt maps the window (this seems
to be the case already).
- you don't seem to free the created asvisual anywhere, bug?
- make it dependent on ENABLE_FRILLS
- add the neccessary documentation (rxvt.1.pod)
and I would happily have it in the next release.
> > If this were an optional perl extension, I would have no problems with
> > it, but forcing it into the core doesn't seem to be that useful for most
> > people.
>
> Is there a chance to set window manager hints from perl?
If you mean properties, yes, if you mean wmhints, not so easily, but you
don't need them. The biggets blocker would have been lack of access to
asimage.
Note that the wm-spec doesn't say applications can set _NET_WM_ICON, so
the whole icon-setting thing is not quite standardised either.
--
The choice of a Deliantra, the free code+content MORPG
-----==- _GNU_ http://www.deliantra.net
----==-- _ generation
---==---(_)__ __ ____ __ Marc Lehmann
--==---/ / _ \/ // /\ \/ / [EMAIL PROTECTED]
-=====/_/_//_/\_,_/ /_/\_\
_______________________________________________
rxvt-unicode mailing list
[email protected]
http://lists.schmorp.de/cgi-bin/mailman/listinfo/rxvt-unicode
