Marc Lehmann <[EMAIL PROTECTED]> writes: > On Mon, Oct 27, 2008 at 09:23:25AM +0100, Frank Schmitt <[EMAIL PROTECTED]> > wrote: >> > Well, first of all, when you send patches, as a very minimum, use the same >> > style as the problem you send patches for. >> >> I don't understand this sentence. > > sorry that's not your fault :) replace "problem" by "program" - i was also > debugging a linux kernel bug while writing that sentence :)
Ah, makes much more sense. I'll do my best. >> > place for this is still the window manager, and working around stupid >> > design >> > bugs in e.g. kde is not really the job of urxvt. >> >> My opinion differs but you are the maintainer. (BTW: The patch is not >> needed for KDE. But for e.g. for Gnome, Xfce, Fluxbox) > > I just had basically a four hour talk about your patch, and here is the deal: > > - the code seems to be broken - _NET_WM_ICON expects cardinals, and thus > an array of longs, but you seem to pass in two int's followed by bytes? > you would need to fix this. I'm rather sure this is correct. The arguments are two integers specifying width and height of the image followed by the image data, 4 bytes per Pixel (ARGB). However I will have one more look at it. > - similarly, are you sure there isn't any endianness issue in the conversion? > does it really work on big-endian systems? The conversion is done completely by afterimage and I map the converted bytes 1-to-1 to the byte array for X. However I will try the code on a non-Intel Mac. > - fix the coding style to be the same as the rest of the code (especially > the indentation which is weird, but also curly braces and > whitespace). Ok. > - make sure you set the property before urxvt maps the window (this seems > to be the case already). > - you don't seem to free the created asvisual anywhere, bug? Probably a bug, yes. I'll have a look. > - make it dependent on ENABLE_FRILLS Ok. > - add the neccessary documentation (rxvt.1.pod) Ok. I'll try to look at the issues next weekend. Yours, Frank -- Have you ever considered how much text can fit in eighty columns? Given that a signature typically contains up to four lines of text, this space allows you to attach a tremendous amount of valuable information to your messages. Seize the opportunity and don't waste your signature on bullshit that nobody cares about. _______________________________________________ rxvt-unicode mailing list [email protected] http://lists.schmorp.de/cgi-bin/mailman/listinfo/rxvt-unicode
