On Fri, Jan 06, 2012 at 05:07:10PM -0400, Jim Diamond wrote:
> On Fri, Jan 6, 2012 at 14:02 (+0100), Emanuele Giaquinta wrote:
>
> > On Thu, Jan 05, 2012 at 04:11:40PM -0400, Jim Diamond wrote:
> >> On Thu, Jan 5, 2012 at 20:08 (+0100), Emanuele Giaquinta wrote:
>
> >>> On Thu, Jan 05, 2012 at 04:03:11PM +0000, Thomas Adam wrote:
>
> >>>> Setting width/height like this is just bogus; when tabbed changes the
> >>>> window size via XMoveResizeWindow() the resize increment hints are
> >>>> honoured *because* the resultant window with tabbed drawn falls within
> >>>> the boundaries.
>
> >>> Bogus why? Note that width and height are the dimensions of the terminal
> >>> (vt) window, not of the main (parent) window. However, looking at the
> >>> tabbed extension, I see that it uses $term->{width,height} in
> >>> 'configure' to resize the main window, and $term->{width,height}
> >>> (bogusly?) map to the corresponding dimension of the terminal window.
> >>> This is possibly the reason of the bug. I think the fix is to have
> >>> $term->width and $term->height return the corresponding dimension of the
> >>> main window. Does the attached patch solve the problem?
>
> >> Your patch also solves the problem (in the sense that it also makes my
> >> tabbedex work-arounds work in 9.14 + your patch).
>
> >> The tabbed extension still opens the window at the wrong size. I
> >> don't have the perspective on the overall system to know whether that
> >> indicates a problem with the perl interface or the tabbed extension.
>
> > Hmm, so it's the same in tabbed with or without my patch? Can you
> > provide a screenshot?
> Attached is an image of 9.14, with your patch, started with
> urxvt -pe tabbed
> where I am using next scrollbars (except my next scrollbars are 2
> pixels less wide than the usual ones). I am using a 7x13bold font,
> URxvt.tabbed.title: False
> URxvt.tabbed.autohide: True
> and other resources which I don't see as being relevant.
Scratch my patch. Tabbed wants to overlay tabs on the inner space (not
including borders and scrollbar) of the main window. In urxvt < 9.14 the
inner space size and the vt window size are equal, so using
$term->width/height works. Now we need two new accessors that tabbed,
tabbedex and other extensions can use to query the inner dimensions.
Emanuele
_______________________________________________
rxvt-unicode mailing list
[email protected]
http://lists.schmorp.de/cgi-bin/mailman/listinfo/rxvt-unicode
