On Sun, 20 May 2012 12:26:14 +0900
Isaku Yamahata <[email protected]> wrote:

> On Sat, May 19, 2012 at 10:07:55PM +0900, FUJITA Tomonori wrote:
> > On Fri, 18 May 2012 10:22:09 +0900 (JST)
> > FUJITA Tomonori <[email protected]> wrote:
> > 
> > > On Fri, 18 May 2012 10:01:21 +0900
> > > Isaku Yamahata <[email protected]> wrote:
> > > 
> > >> On Thu, May 17, 2012 at 11:28:36PM +0900, FUJITA Tomonori wrote:
> > >>> OFPStatsReply needs to handle variable-length bodys (flow stats) so
> > >>> having two parsers (parser_stats_body_array and parser_stats_body)
> > >>> doesn't make sense. Just kill parser_stats_body_array().
> > >> 
> > >> The returned type for struct ofp_stats_request are classified in 2 cases.
> > >> 
> > >> - single sturct
> > >>   struct ofp_desc_stats
> > >> 
> > >> - array of struct
> > >>   struct ofp_flow_stats, struct ofp_aggregate_stats_reply
> > >>   struct ofp_port_stats, struct ofp_queue_stats
> > > 
> > > Yeah, and I don't see any problem about always handling struct as an
> > > array. ofp_desc_stats is just a single array.
> > 
> > ok, if we had better to keep the data structure for ofp_desc_stats,
> > how about the following?
> 
> Looks good.
> Reviewed-by: Isaku Yamahata <[email protected]>

Applied, thanks.

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel

Reply via email to