Hi,

here is the updated version of that patch. Let me know if this looks OK.

Thanks,
Sriram

On Wed, Sep 24, 2014 at 12:03 AM, Yusuke Iwase <[email protected]>
wrote:

> Hi,
>
> I checked and tested your patch
> (0001-Fix-spell-check-in-group-feature-message.patch)
> and found a impact for rest_qos.py usage.
>
> ---
> ryu/app/rest_qos.py
> ---
>   159 #  request body format:
>   160 #   {"meter_id": <int>,
>   161 #    "bands":[{"action": "<DROP or REMARK>",            <--- HERE
>   162 #              "flag": "<KBPS or PKTPS or BURST or STATS"
>   163 #              "burst_size": <int>,
>   164 #              "rate": <int>,
>   165 #              "prec_level": <int>},...]}
> ---
>
> Could you fix this comment line, and include ryu/app/rest_qos.py to your
> patch ?
>
> On 2014年09月22日 11:35, Sriram wrote:
> > Hi,
> >
> > Attached are 2patches:
> >
> > *0001-Fix-spell-check-in-group-feature-message.patch:
> > *
> >
> > The above patch fixes some spell check and improves consistency when
> calling DSCP_REMARK meter type
> >
> > *0001-Improve-debug-messages-for-unsupported-request.patch*
> > *
> > *
> > This patch improves the debug messages for unsupported request.
> Previously, when a request is not supported in that OF protocol version, it
> logs as "Unsupported OF protocol" which is incorrect. The switch might
> still support that OF protocol. So this patch improves the debug message to
> log as "Request not supported in this OF protocol version"
> >
> > Hope this helps.
> >
> > Thanks,
> > Sriram
> >
> >
> >
> ------------------------------------------------------------------------------
> > Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
> > Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
> > Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
> > Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
> >
> >
> >
> > _______________________________________________
> > Ryu-devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/ryu-devel
> >
>

Attachment: 0001-Fix-spell-check-in-group-feature-message.patch
Description: Binary data

------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel

Reply via email to