Hi Kawai-San,
Thank you for your nice patch!
On 2016年07月06日 20:06, Kawai, Hiroaki wrote:
> To test VLAN_PCP, we must set matcing VLAN_VID.
> Table miss test was testing VLAN_VID instead of VLAN_PCP,
> because the packet had mismatching VLAN_VID.
Additionally, how about setting vlan_vid=(OFPVID_PRESENT, OFPVID_PRESENT) as
following?
$ git diff
diff --git a/ryu/tests/switch/of13/match/07_VLAN_PCP.json
b/ryu/tests/switch/of13/match/07_VLAN_PCP.json
index 208b8a5..54f3450 100644
--- a/ryu/tests/switch/of13/match/07_VLAN_PCP.json
+++ b/ryu/tests/switch/of13/match/07_VLAN_PCP.json
@@ -12,8 +12,8 @@
{
"OXMTlv":{
"field":"vlan_vid",
- "mask":null,
- "value":4196
+ "mask":4096,
+ "value":4096
}
},
{
...
...
Even if the input packet has an incorrect VLAN_VID like this test case,
we can test the VLAN_PCP match capability, I think.
Thanks,
Iwase
> ---
> ryu/tests/switch/of13/match/07_VLAN_PCP.json | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ryu/tests/switch/of13/match/07_VLAN_PCP.json
> b/ryu/tests/switch/of13/match/07_VLAN_PCP.json
> index 208b8a5..118cb1f 100644
> --- a/ryu/tests/switch/of13/match/07_VLAN_PCP.json
> +++ b/ryu/tests/switch/of13/match/07_VLAN_PCP.json
> @@ -169,7 +169,7 @@
> {
> "ingress":[
> "ethernet(dst='ba:bb:bb:bb:bb:bb',
> src='aa:aa:aa:aa:aa:aa', ethertype=33024)",
> - "vlan(pcp=5, cfi=0, vid=203, ethertype=2048)",
> + "vlan(pcp=5, cfi=0, vid=100, ethertype=2048)",
> "ipv4(tos=65, proto=6, src='10.10.10.10',
> dst='10.10.20.20', ttl=127)",
> "tcp(dst_port=6789, option=bytes(b'\\x01' * 4),
> src_port=12345)",
>
> "b'\\x01\\x02\\x03\\x04\\x05\\x06\\x07\\x08\\t\\n\\x0b\\x0c\\r\\x0e\\x0f\\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17\\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f'"
> @@ -349,7 +349,7 @@
> {
> "ingress":[
> "ethernet(dst='ba:bb:bb:bb:bb:bb',
> src='aa:aa:aa:aa:aa:aa', ethertype=33024)",
> - "vlan(pcp=5, cfi=0, vid=203, ethertype=34525)",
> + "vlan(pcp=5, cfi=0, vid=100, ethertype=34525)",
> "ipv6(dst='b0::b0', flow_label=203, src='a0::a0',
> nxt=6, hop_limit=127, traffic_class=65)",
> "tcp(dst_port=6789, option=bytes(b'\\x01' * 4),
> src_port=12345)",
>
> "b'\\x01\\x02\\x03\\x04\\x05\\x06\\x07\\x08\\t\\n\\x0b\\x0c\\r\\x0e\\x0f\\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17\\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f'"
> @@ -525,7 +525,7 @@
> {
> "ingress":[
> "ethernet(dst='ba:bb:bb:bb:bb:bb',
> src='aa:aa:aa:aa:aa:aa', ethertype=33024)",
> - "vlan(pcp=5, cfi=0, vid=203, ethertype=2054)",
> + "vlan(pcp=5, cfi=0, vid=100, ethertype=2054)",
> "arp(dst_ip='10.10.20.20',dst_mac='ba:bb:bb:bb:bb:bb',
> opcode=2, src_ip='10.10.10.10',src_mac='aa:aa:aa:aa:aa:aa')",
> "bytes(b'\\x00' * 30)"
> ],
>
------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel
