Hi Kawai-San,

Thank you for updating your patch!

It looks good to me.

Thanks,
Iwase


On 2016年07月07日 12:01, Kawai, Hiroaki wrote:
> To test VLAN_PCP, VLAN_VID must match.
> Table miss test was testing VLAN_VID instead of VLAN_PCP,
> because the packet had mismatching VLAN_VID.
> Fixes to set only OFPVID_PRESENT bit in the match field.
> ---
>   ryu/tests/switch/of13/match/07_VLAN_PCP.json | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/ryu/tests/switch/of13/match/07_VLAN_PCP.json 
> b/ryu/tests/switch/of13/match/07_VLAN_PCP.json
> index 208b8a5..132fe76 100644
> --- a/ryu/tests/switch/of13/match/07_VLAN_PCP.json
> +++ b/ryu/tests/switch/of13/match/07_VLAN_PCP.json
> @@ -135,8 +135,8 @@
>                                   {
>                                       "OXMTlv":{
>                                           "field":"vlan_vid",
> -                                        "mask":null,
> -                                        "value":4196
> +                                        "mask":4096,
> +                                        "value":4096
>                                       }
>                                   },
>                                   {
> @@ -315,8 +315,8 @@
>                                   {
>                                       "OXMTlv":{
>                                           "field":"vlan_vid",
> -                                        "mask":null,
> -                                        "value":4196
> +                                        "mask":4096,
> +                                        "value":4096
>                                       }
>                                   },
>                                   {
> @@ -491,8 +491,8 @@
>                                   {
>                                       "OXMTlv":{
>                                           "field":"vlan_vid",
> -                                        "mask":null,
> -                                        "value":4196
> +                                        "mask":4096,
> +                                        "value":4096
>                                       }
>                                   },
>                                   {
>

------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel

Reply via email to