Hi Ymamamoto-San and Fujita-San,
On 2016年07月27日 20:42, Takashi YAMAMOTO wrote: > > > On Wed, Jul 27, 2016 at 7:53 PM, FUJITA Tomonori <[email protected] > <mailto:[email protected]>> wrote: > > On Wed, 27 Jul 2016 19:29:58 +0900 > Takashi YAMAMOTO <[email protected] <mailto:[email protected]>> wrote: > > > On Wed, Jul 27, 2016 at 11:35 AM, Shinpei Muraoka > <[email protected] <mailto:[email protected]> > >> wrote: > > > >> This patch will revert the API of NXAction for the following report. > >> https://bugs.launchpad.net/dragonflow/+bug/1599367 > >> revert commit id: 3c3896fd77f274ce953dcb78795aa5cc4fde6c65 > >> > >> This patch reverts recently introduced start and end arguments. > >> Add the utility method for ofs_nbits. > >> NXActionRegLoad now takes ofs_nbits argument instead of ofs > >> and nbits even with this revert. > >> > > > > is this necessary? > > > > FYI, there's unmerged dragonflow patch which uses NXActionRegLoad. > > > https://review.openstack.org/#/c/309746/9/dragonflow/controller/metadata_service_app.py@255 > > Thanks for the pointer. IIRC the discussion, there are some NXAction > takes ofs_nbits instead of ofs and nbits. So taking ofs_nbits is more > consistent with the rests? We could add a workaround for this. > > > it isn't that consistent anyway. > 1.3 regload is not the only action which takes separte ofs and nbits. > eg. regmove uses separate arguments too. The policy of NXActions support is to align with "on-wire" fields of OVS, right? I think NXActionRegLoad was the only action which does not align with on-wire fields, and has separated ofs_nbits fields. https://github.com/openvswitch/ovs/blob/master/lib/ofp-actions.c#L2438 All the other NXActions align with on-wire fields. As you said, NXActionRegMove have separate arguments, but it is aligned with "on-wire" fields of OVS. https://github.com/openvswitch/ovs/blob/master/lib/ofp-actions.c#L2228-L2230 Thanks, Iwase > > > > ------------------------------------------------------------------------------ > What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic > patterns at an interface-level. Reveals which users, apps, and protocols are > consuming the most bandwidth. Provides multi-vendor support for NetFlow, > J-Flow, sFlow and other flows. Make informed decisions using capacity planning > reports.http://sdm.link/zohodev2dev > > > > _______________________________________________ > Ryu-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ryu-devel > ------------------------------------------------------------------------------ _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
