At Wed, 27 Jul 2016 11:35:56 +0900, Shinpei Muraoka wrote: > > Since zone_src in NXActionCT was not possible to specify string, > update zone_src of NXActionCT for the uniformity. > Therefore, you will be able to specify string of OXM/NXM fields for zone_src. > > If you want to set the immediate value for zone, > zone_src set the None or empty character string. > > Signed-off-by: Shinpei Muraoka <[email protected]> > ---
Are you going to disallow numeric zone_src in future? > diff --git > a/ryu/tests/unit/ofproto/json/of13/ovs-ofctl-of13-action_ct.packet.json > b/ryu/tests/unit/ofproto/json/of13/ovs-ofctl-of13-action_ct.packet.json > index 0cd1e20..b1157e9 100644 > --- a/ryu/tests/unit/ofproto/json/of13/ovs-ofctl-of13-action_ct.packet.json > +++ b/ryu/tests/unit/ofproto/json/of13/ovs-ofctl-of13-action_ct.packet.json > @@ -21,8 +21,8 @@ > "recirc_table": 4, > "subtype": 35, > "type": 65535, > - "zone_ofs_nbits": 0, > - "zone_src": 0 > + "zone_ofs_nbits": 283, > + "zone_src": "reg0" > } > } > ], It would have been better to keep tests that confirm numeric zone_src works, but I think it's a bit tiresome to do considering how tests are genereted. Other than that, I'm fine with this patch. > diff --git > a/ryu/tests/unit/ofproto/json/of13/ovs-ofctl-of13-action_ct_exec.packet.json > b/ryu/tests/unit/ofproto/json/of13/ovs-ofctl-of13-action_ct_exec.packet.json > index a163aba..e3fcd3b 100644 > --- > a/ryu/tests/unit/ofproto/json/of13/ovs-ofctl-of13-action_ct_exec.packet.json > +++ > b/ryu/tests/unit/ofproto/json/of13/ovs-ofctl-of13-action_ct_exec.packet.json > @@ -36,7 +36,7 @@ > "subtype": 35, > "type": 65535, > "zone_ofs_nbits": 0, > - "zone_src": 0 > + "zone_src": "" > } > } > ], > diff --git > a/ryu/tests/unit/ofproto/json/of13/ovs-ofctl-of13-action_ct_nat.packet.json > b/ryu/tests/unit/ofproto/json/of13/ovs-ofctl-of13-action_ct_nat.packet.json > index ef6a7d9..5a38d8f 100644 > --- > a/ryu/tests/unit/ofproto/json/of13/ovs-ofctl-of13-action_ct_nat.packet.json > +++ > b/ryu/tests/unit/ofproto/json/of13/ovs-ofctl-of13-action_ct_nat.packet.json > @@ -38,7 +38,7 @@ > "subtype": 35, > "type": 65535, > "zone_ofs_nbits": 0, > - "zone_src": 0 > + "zone_src": "" > } > } > ], > diff --git > a/ryu/tests/unit/ofproto/json/of13/ovs-ofctl-of13-action_ct_nat_v6.packet.json > > b/ryu/tests/unit/ofproto/json/of13/ovs-ofctl-of13-action_ct_nat_v6.packet.json > index cca4625..5c1c8c0 100644 > --- > a/ryu/tests/unit/ofproto/json/of13/ovs-ofctl-of13-action_ct_nat_v6.packet.json > +++ > b/ryu/tests/unit/ofproto/json/of13/ovs-ofctl-of13-action_ct_nat_v6.packet.json > @@ -38,7 +38,7 @@ > "subtype": 35, > "type": 65535, > "zone_ofs_nbits": 0, > - "zone_src": 0 > + "zone_src": "" > } > } > ], > -- > 1.9.1 > > > ------------------------------------------------------------------------------ > What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic > patterns at an interface-level. Reveals which users, apps, and protocols are > consuming the most bandwidth. Provides multi-vendor support for NetFlow, > J-Flow, sFlow and other flows. Make informed decisions using capacity planning > reports.http://sdm.link/zohodev2dev > _______________________________________________ > Ryu-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/ryu-devel > ------------------------------------------------------------------------------ _______________________________________________ Ryu-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ryu-devel
