Kwankyu Lee <[email protected]> writes: > Hi, > > The patchbot is failing(ApplyFailed) on my patch for ticket #12503. I want to > understand the reason. > > According to the log below, the patchbot seems to try to fetch the file at > > http://trac.sagemath.org/sage_trac/raw-attachment/ticket/12503/trac#12503.patch > > I copied this line into the browser's address bar. I also received an error. > On the other hand, I noticed that > > http://trac.sagemath.org/sage_trac/raw-attachment/ticket/12503/trac%2312503.patch > > works fine (# is replaced with %23). Is the patchbot try to fetch a file by a > wrong-formed address? Is this a bug in the patchbot? > ... > ... > Looking at #12503 > http://trac.sagemath.org/sage_trac/raw-attachment/ticket/12503/trac#12503.patch > Traceback (most recent call last): > File "/opt/patchbot-5.1.rc1/local/bin/patchbot/patchbot.py", line 254, in > test_a_ticket > pull_from_trac(sage_root, ticket['id'], force=True) > File "/opt/patchbot-5.1.rc1/local/bin/patchbot/trac.py", line 317, in > pull_from_trac > append_patch_list(ticket) > File "/opt/patchbot-5.1.rc1/local/bin/patchbot/trac.py", line 295, in > append_patch_list > data = scrape(ticket) > File "/opt/patchbot-5.1.rc1/local/bin/patchbot/trac.py", line 73, in scrape > patches.append(patch + "#" + digest(get_patch(ticket_id, patch))) > File "/opt/patchbot-5.1.rc1/local/bin/patchbot/trac.py", line 34, in > get_patch > return get_url(get_patch_url(ticket, patch)) > File "/opt/patchbot-5.1.rc1/local/bin/patchbot/trac.py", line 19, in get_url > handle = urllib2.urlopen(url, timeout=5) > File "/opt/patchbot-5.1.rc1/local/lib/python/urllib2.py", line 126, in > urlopen > return _opener.open(url, data, timeout) > File "/opt/patchbot-5.1.rc1/local/lib/python/urllib2.py", line 406, in open > response = meth(req, response) > File "/opt/patchbot-5.1.rc1/local/lib/python/urllib2.py", line 519, in > http_response > 'http', request, response, code, msg, hdrs) > File "/opt/patchbot-5.1.rc1/local/lib/python/urllib2.py", line 444, in error > return self._call_chain(*args) > File "/opt/patchbot-5.1.rc1/local/lib/python/urllib2.py", line 378, in > _call_chain > result = func(*args) > File "/opt/patchbot-5.1.rc1/local/lib/python/urllib2.py", line 527, in > http_error_default > raise HTTPError(req.get_full_url(), code, msg, hdrs, fp) > HTTPError: HTTP Error 404: Not Found > 2012-07-10 00:07:24 +0800 > 34 seconds
Looks like a bug to me. The URL should be encoded properly. In particular the following line needs to be a bit more robust: https://github.com/robertwb/sage-patchbot/blob/master/trac.py#L14 -Keshav ---- Join us in #sagemath on irc.freenode.net ! -- -- To post to this group, send an email to [email protected] To unsubscribe from this group, send an email to [email protected] For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
