On Thu, Jan 2, 2014 at 1:49 AM, Simon King <[email protected]> wrote: > Hi John, > > On 2014-01-02, John Cremona <[email protected]> wrote: >> It is rather frequent that some commit gets a positive review (e.g. >> from me) only to be reverted to "needs work" by someone else (e.g. one >> of our excellent release managers ;)). If the list of commits coming >> from dependencies of ticket 2 could be shown with tags showing their >> review status, that would be nice, though not very well-defined since >> ticket 1 might have had a series of serveral commits and only the >> complete set of changes they represent has the positive review, not >> the individual component commits. > > Additional problem: According to Volker there is no ticket to which a > specific commit belongs. > > To me, the punch line seems to be that git is orthogonal to trac. I > thought that Sage's bugs are dealt with on trac. Hence, we need a trac > workflow, not a workflow that relies on notions (namely: commits) that > are orthogonal to the notions relevant to trac (namely: tickets).
Correct, git and trac aren't entirely orthogonal, but you're right there's a discrepancy. My preference would be to move even further away from forcing a trac-based workflow 'cause with git you're not forced into using one workflow/set of tools and the skills are transferable (in and out) and there's a lot more resources out there. So I would propose that every *commit* that goes into Sage needs to be positively reviewed. Tickets are (possibly changing, typically monotonically) sets of commits, excluding the commits of dependencies. Setting a ticket to positive review marks the current set of commits as positively reviewed; if this set changes (due to changes in dependencies or further work) this positive review is automatically set back, but the commits that were previously reviewed are still marked as such. - Robert -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/groups/opt_out.
