Hey William, That diff looks like it is from Peter's branch which reverts some of my changes (and is the current branch posted on the ticket). I added that method in case someone wanted to access the defining list passed to ManinSymbolList (perhaps this is a dumb thing to do). I will be careful with my benchmarks when I run them.
Best, Travis On Sunday, January 4, 2015 7:52:36 AM UTC-8, William wrote: > > On Sun, Jan 4, 2015 at 7:26 AM, Travis Scrimshaw <[email protected] > <javascript:>> wrote: > > Hey William, > > > >> > >> Does your change impact performance? > > > > > > I don't completely know. I believe it will not as I think most of the > > time people would create an instance of ManinSymbol from ManinSymbolList > > I just looked at the diff at > > > http://git.sagemath.org/sage.git/diff/?h=e59b940b36c40cca506f7740a480c47369920309 > > > Why do you completely get rid of "def symbol_list(self):"? I don't > know if I or anybody else > wrote code -- not included officially in Sage -- that called that > method over the last ten years, > but it seems likely. Why not leave it? Or at worst, leave it, but > deprecate it and remove it > a year from now? > > > (plus it uses caching that was there prior to these changes), so there > won't > > be a performance hit from that. There's a good probability that > > ManinSymbolList should be a UniqueRepresentation, but the > manin_symbols() > > method is currently cached, so we won't see a performance hit that way. > So > > if you're creating instances of (subclasses of) ManinSymbolList directly > > frequently, then you might see a hit, but I suspect that's bad usage. > Thus I > > don't see any uses where it could result it a slowdown, but perhaps > > ManinSymbolList is being used in ways I don't know of. I will run some > > timings with some possible ways I see this being used. > > > > > > Hey John. > > > >> Can you copy this post to sage-nt? > >> > >> John > > > > > > I applied to sage-nt, so once I join, I will cross-post. > > > > Best, > > Travis > > > > -- > > You received this message because you are subscribed to the Google > Groups > > "sage-devel" group. > > To unsubscribe from this group and stop receiving emails from it, send > an > > email to [email protected] <javascript:>. > > To post to this group, send email to [email protected] > <javascript:>. > > Visit this group at http://groups.google.com/group/sage-devel. > > For more options, visit https://groups.google.com/d/optout. > > > > -- > William Stein > Professor of Mathematics > University of Washington > http://wstein.org > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
